Skip to content

Add a test for the connection validator of ClientConfiguration (apache/pulsar-client-cpp#630) - #3

Open
alexey-milovidov wants to merge 3 commits into
clickhousefrom
upstream-pr-630
Open

alexey-milovidov wants to merge 3 commits into
clickhousefrom
upstream-pr-630

Conversation

@alexey-milovidov

Copy link
Copy Markdown
Member

Merges the upstream pull request apache#630 into the clickhouse branch.

The connection validator is already in clickhouse as dfc2686, and the library part of the upstream pull request is identical to it. This pull request adds the remaining part, the test ClientTest.testConnectionValidator.

Related: apache#630
Related: ClickHouse/ClickHouse#64184

🤖 Generated with Claude Code

alexey-milovidov and others added 3 commits November 13, 2026 23:38
Applications embedding the client may need to constrain the set of hosts
the client is allowed to dial. Validating only the service URL is not
enough: the client follows lookup responses and connects to the returned
broker addresses directly. Every physical connection goes through
ConnectionPool::getConnectionAsync, so invoke an application-provided
validator there and reject the connection attempt with ResultConnectError
when the validator returns false.

Rebased onto apache/pulsar-client-cpp main: the connection future carries an `Error` since apache#579.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The connection validator of `ClientConfiguration` is already in the
`clickhouse` branch as dfc2686. The merge adds the test from the
upstream pull request, `ClientTest.testConnectionValidator`.

apache#630

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants