Repository navigation
Add a test for the connection validator of ClientConfiguration (apache/pulsar-client-cpp#630) - #3
Open
alexey-milovidov wants to merge 3 commits into
Open
alexey-milovidov wants to merge 3 commits into
alexey-milovidov wants to merge 3 commits into
Conversation
Applications embedding the client may need to constrain the set of hosts the client is allowed to dial. Validating only the service URL is not enough: the client follows lookup responses and connects to the returned broker addresses directly. Every physical connection goes through ConnectionPool::getConnectionAsync, so invoke an application-provided validator there and reject the connection attempt with ResultConnectError when the validator returns false. Rebased onto apache/pulsar-client-cpp main: the connection future carries an `Error` since apache#579.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The connection validator of `ClientConfiguration` is already in the `clickhouse` branch as dfc2686. The merge adds the test from the upstream pull request, `ClientTest.testConnectionValidator`. apache#630 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the upstream pull request apache#630 into the
clickhousebranch.The connection validator is already in
clickhouseas dfc2686, and the library part of the upstream pull request is identical to it. This pull request adds the remaining part, the testClientTest.testConnectionValidator.Related: apache#630
Related: ClickHouse/ClickHouse#64184
🤖 Generated with Claude Code